refactor(vscode): inject translator and workspace #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strager
approved these changes
Jan 21, 2024
| diag_reporter.report(loaded_config->errors); | ||
| return std::move(diag_reporter).diagnostics(); | ||
| } | ||
| Loaded_Config_File* loaded_config_ = nullptr; |
There was a problem hiding this comment.
Nit: Ideally the changes related to loaded_config_ would be done in a separate patch. I have some opinions on it. But I'll let this slide...
Summary: This commit refactors the global translator class into a variable injected into the VSCode workspace, and gives the workspace as an argument to QLJS_Lintable_Document. This refactor clears the way for adding snarky and language settings for VSCode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(vscode): inject translator and workspace
Summary: This commit refactors the global translator class into a variable
injected into the VSCode workspace, and gives the workspace as an argument to
QLJS_Lintable_Document.
This refactor clears the way for adding snarky and language settings for VSCode
Stack created with Sapling. Best reviewed with ReviewStack.