Skip to content

Commit

Permalink
fix(vscode): fix corrupted VS Code downloads in testing
Browse files Browse the repository at this point in the history
'yarn test' downloads Visual Studio Code into a temporary directory. A
change in Visual Studio Code's server caused the download to break [1].
Example error message on Windows:

    Test error: Error: spawn
    P:\quick-lint-js\plugin\vscode\.vscode-test\vscode-win32-x64-archive-1.55.2\Code.exe ENOENT
    Exit code:   -4058

Fix the broken downloading by applying a patch to the download
script [2].

[1] microsoft/vscode-test#246
[2] microsoft/vscode-test@62881f0
  • Loading branch information
strager committed Feb 17, 2024
1 parent 748b775 commit ab04ec9
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 7 deletions.
2 changes: 1 addition & 1 deletion plugin/vscode/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
"test": "node test/run-vscode-tests.js"
},
"devDependencies": {
"@vscode/test-electron": "2.3.0",
"@vscode/test-electron": "2.3.9",
"colors": "1.4.0",
"prettier": "2.8.4",
"vsce": "2.15.0"
Expand Down
19 changes: 13 additions & 6 deletions plugin/vscode/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@
resolved "https://registry.yarnpkg.com/@tootallnate/once/-/once-1.1.2.tgz#ccb91445360179a04e7fe6aff78c00ffc1eeaf82"
integrity sha512-RbzJvlNzmRq5c3O09UipeuXno4tA1FE6ikOjxZK0tuxVv3412l64l5t1W5pj4+rJq9vpkm/kwiR07aZXnsKPxw==

"@vscode/[email protected].0":
version "2.3.0"
resolved "https://registry.yarnpkg.com/@vscode/test-electron/-/test-electron-2.3.0.tgz#de0ba2f5d36546a83cd481b458cbdbb7cc0f7049"
integrity sha512-fwzA9RtazH1GT/sckYlbxu6t5e4VaMXwCVtyLv4UAG0hP6NTfnMaaG25XCfWqlVwFhBMcQXHBCy5dmz2eLUnkw==
"@vscode/[email protected].9":
version "2.3.9"
resolved "https://registry.yarnpkg.com/@vscode/test-electron/-/test-electron-2.3.9.tgz#f61181392634b408411e4302aef6e1cd2dd41474"
integrity sha512-z3eiChaCQXMqBnk2aHHSEkobmC2VRalFQN0ApOAtydL172zXGxTwGrRtviT5HnUB+Q+G3vtEYFtuQkYqBzYgMA==
dependencies:
http-proxy-agent "^4.0.1"
https-proxy-agent "^5.0.0"
jszip "^3.10.1"
semver "^7.3.8"
semver "^7.5.2"

agent-base@6:
version "6.0.2"
Expand Down Expand Up @@ -676,13 +676,20 @@ semver@^5.1.0:
resolved "https://registry.yarnpkg.com/semver/-/semver-5.7.1.tgz#a954f931aeba508d307bbf069eff0c01c96116f7"
integrity sha512-sauaDf/PZdVgrLTNYHRtpXa1iRiKcaebiKQ1BJdpQlWH2lCvexQdX55snPFyK7QzpudqbCI0qXFfOasHdyNDGQ==

semver@^7.3.5, semver@^7.3.8:
semver@^7.3.5:
version "7.3.8"
resolved "https://registry.yarnpkg.com/semver/-/semver-7.3.8.tgz#07a78feafb3f7b32347d725e33de7e2a2df67798"
integrity sha512-NB1ctGL5rlHrPJtFDVIVzTyQylMLu9N9VICA6HSFJo8MCGVTMW6gfpicwKmmK/dAjTOrqu5l63JJOpDSrAis3A==
dependencies:
lru-cache "^6.0.0"

semver@^7.5.2:
version "7.6.0"
resolved "https://registry.yarnpkg.com/semver/-/semver-7.6.0.tgz#1a46a4db4bffcccd97b743b5005c8325f23d4e2d"
integrity sha512-EnwXhrlwXMk9gKu5/flx5sv/an57AkRplG3hTK68W7FRDN+k+OWBj65M7719OkA82XLBxrcX0KSHj+X5COhOVg==
dependencies:
lru-cache "^6.0.0"

setimmediate@^1.0.5:
version "1.0.5"
resolved "https://registry.yarnpkg.com/setimmediate/-/setimmediate-1.0.5.tgz#290cbb232e306942d7d7ea9b83732ab7856f8285"
Expand Down

0 comments on commit ab04ec9

Please sign in to comment.