Skip to content

Conversation

@mohiso22
Copy link
Contributor

No description provided.

Signed-off-by: Mohit Soni <[email protected]>
@mohiso22 mohiso22 marked this pull request as ready for review December 23, 2025 07:04
)

if self.vae_decoder.qpc_session is None:
self.vae_decoder.qpc_session = QAICInferenceSession(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: will this be reusing the same set of device_ids post DIT is done?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the qpc loading as well here, refer flux pipeline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, will update it now

specializations (List[Dict]): Model specialization configurations
**compiler_options: Additional compiler options
"""
self._compile(specializations=specializations, **compiler_options)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: currently "-aic-hmx-conv3d" flag is part of the assert-sdk, this will soon be in the release sdk and we should enable it by default once it's in.

)

if self.vae_decoder.qpc_session is None:
self.vae_decoder.qpc_session = QAICInferenceSession(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the qpc loading as well here, refer flux pipeline.

@quic-amitraj
Copy link
Contributor

Refer flux pipeline for the changes and removed not needed class.

},
]
],
"vae_decoder": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was some error without this, so temporary did list by default

@quic-amitraj
Copy link
Contributor

To handle two different types of get_onnx_params for image and video pipelines, let's have two different methods like this:
def get_onnx_image_params(self)

def get_onnx_video_params(self)

Later inside init of pipeline map with the desired method with get_onnx_params like this-
self.vae_decode.get_onnx_params= self.vae_decode.get_onnx_image_params

@quic-amitraj
Copy link
Contributor

To handle two different types of get_onnx_params for image and video pipelines, let's have two different methods like this: def get_onnx_image_params(self)

def get_onnx_video_params(self)

Later inside init of pipeline map with the desired method with get_onnx_params like this- self.vae_decode.get_onnx_params= self.vae_decode.get_onnx_image_params

update flux init as well to reflect this changes.

Mohit Soni added 3 commits December 23, 2025 17:33
Signed-off-by: Mohit Soni <[email protected]>
Signed-off-by: Mohit Soni <[email protected]>
Signed-off-by: Mohit Soni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants