-
Notifications
You must be signed in to change notification settings - Fork 63
Adding Vae Decoder in Wan #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Mohit Soni <[email protected]>
| ) | ||
|
|
||
| if self.vae_decoder.qpc_session is None: | ||
| self.vae_decoder.qpc_session = QAICInferenceSession( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: will this be reusing the same set of device_ids post DIT is done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put the qpc loading as well here, refer flux pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet, will update it now
| specializations (List[Dict]): Model specialization configurations | ||
| **compiler_options: Additional compiler options | ||
| """ | ||
| self._compile(specializations=specializations, **compiler_options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: currently "-aic-hmx-conv3d" flag is part of the assert-sdk, this will soon be in the release sdk and we should enable it by default once it's in.
| ) | ||
|
|
||
| if self.vae_decoder.qpc_session is None: | ||
| self.vae_decoder.qpc_session = QAICInferenceSession( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put the qpc loading as well here, refer flux pipeline.
|
Refer flux pipeline for the changes and removed not needed class. |
| }, | ||
| ] | ||
| ], | ||
| "vae_decoder": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there was some error without this, so temporary did list by default
|
To handle two different types of
Later inside init of pipeline map with the desired method with |
update flux init as well to reflect this changes. |
Signed-off-by: Mohit Soni <[email protected]>
Signed-off-by: Mohit Soni <[email protected]>
Signed-off-by: Mohit Soni <[email protected]>
No description provided.