making kv_cache_batch_size equivalent to full_batch_size for prefill-only model #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only model, even though this is not intuitive, being done for vllm interface to be easier Signed-off-by: Onkar Chougule <[email protected]>
ochougul
requested review from
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
ochougul
changed the title
Signed-off-by: Onkar Chougule <[email protected]>
Signed-off-by: Onkar Chougule <[email protected]>
quic-hemagnih
approved these changes
Dec 23, 2025
ochougul
added a commit
that referenced
this pull request
Dec 24, 2025
…only model (#687) This is counter-intuitive but being done for easy interface and less options to play with for DA mode --------- Signed-off-by: Onkar Chougule <[email protected]>
ochougul
added a commit
that referenced
this pull request
Dec 24, 2025
…only model (#687) This is counter-intuitive but being done for easy interface and less options to play with for DA mode --------- Signed-off-by: Onkar Chougule <[email protected]>
ochougul
added a commit
that referenced
this pull request
Dec 24, 2025
…only model (#687) This is counter-intuitive but being done for easy interface and less options to play with for DA mode --------- Signed-off-by: Onkar Chougule <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is counter-intuitive but being done for easy interface and less options to play with for DA mode