[QEff.Finetuning] Added support for SFTTrainer class along with tests #660
+330
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhiraj Kumar Sah <[email protected]>
Added tests in test_trainer which also check for model integration with trainer class created. Some of the tests can later be moved to end to end integration tests. Signed-off-by: Dhiraj Kumar Sah <[email protected]>
quic-dhirajku
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
quic-meetkuma
requested changes
Dec 16, 2025
Contributor
quic-meetkuma
left a comment
quic-meetkuma
left a comment
There was a problem hiding this comment.
I feel some redundant tests can be moved to test_model.py. Rest looks fine.
…rs for a model. Signed-off-by: Dhiraj Kumar Sah <[email protected]>
Contributor
|
PEFT config should be added here in the BaseTrainer class as it is part of training config. trl repo has also added it in the trainer classes. We should not deviate from that. It will make the code reuse difficult at a later stage. Please refer: https://github.com/huggingface/trl/blob/main/trl/trainer/sft_trainer.py Please keep the flexibility to accept PEFT techniques/configuration of various kinds and not just LoRA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.