-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QEff Finetune]: Added support for gradient checkpointing in the finetuning script. #338
Open
quic-meetkuma
wants to merge
11
commits into
quic:main
Choose a base branch
from
quic-meetkuma:grad_checkpointing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+42
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58c13e9
to
0b1c369
Compare
241d5b4
to
82d8ec9
Compare
quic-mamta
reviewed
Apr 9, 2025
quic-mamta
reviewed
Apr 9, 2025
quic-meetkuma
commented
Apr 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add eager team's code reference for qaic_debug API changes.
Signed-off-by: Meet Patel <[email protected]>
Signed-off-by: Meet Patel <[email protected]>
Signed-off-by: Meet Patel <[email protected]>
Signed-off-by: Meet Patel <[email protected]>
Signed-off-by: Meet Patel <[email protected]>
82d8ec9
to
f98dc51
Compare
quic-swatia
requested changes
Apr 9, 2025
quic-meetkuma
commented
Apr 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix couple of comments.
056cea8
to
911e580
Compare
quic-swatia
reviewed
Apr 10, 2025
quic-swatia
reviewed
Apr 10, 2025
Signed-off-by: Meet Patel <[email protected]>
Signed-off-by: Meet Patel <[email protected]>
Signed-off-by: Meet Patel <[email protected]>
Signed-off-by: Meet Patel <[email protected]>
Signed-off-by: Meet Patel <[email protected]>
Signed-off-by: Meet Patel <[email protected]>
0d3c302
to
8e21fe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added --gradient_checkpointing new CLI flag to enable this feature.
Currently this is enabled for all the HF models which has "supports_gradient_checkpointing" attribute set to True.