Skip to content

Added Infra in QEfficient for execution of swiftkv models #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

quic-hemagnih
Copy link
Contributor

Added Infra in QEfficient for execution of models whose modelling file is not present at hugging face and checkpoint like swiftkv

@quic-amitraj quic-amitraj self-requested a review March 13, 2025 12:01
quic-hemagnih and others added 4 commits April 15, 2025 11:26
…e is not present at hugging face and checkpoint like swiftkv

Signed-off-by: Hem Agnihotri <[email protected]>
Signed-off-by: Onkar Chougule <[email protected]>
@quic-hemagnih quic-hemagnih marked this pull request as draft April 15, 2025 11:28
Copy link
Contributor

@ochougul ochougul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets merge once CI passes

@ochougul ochougul marked this pull request as ready for review April 15, 2025 15:27
Copy link
Contributor

@ochougul ochougul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -187,6 +190,103 @@ def check_causal_lm_pytorch_vs_kv_vs_ort_vs_ai100(
assert os.path.isfile(os.path.join(os.path.dirname(qpc_path), "qconfig.json"))


def check_non_hf_kv_vs_ort_vs_ai100(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed that most of the code is same with the check_causal_lm_pytorch_vs_kv_vs_ort_vs_ai100 function except pytorch_hf_token calculation part. Can't we refactor the code in such a way that we can reuse the common code?

@ochougul
Copy link
Contributor

done in #367

@ochougul ochougul closed this Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants