-
Notifications
You must be signed in to change notification settings - Fork 43
SpD, multiprojection heads #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eplatero97
wants to merge
44
commits into
quic:main
Choose a base branch
from
eplatero97:turbo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+858
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
using sdk |
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
ochougul
reviewed
Mar 22, 2025
Loading status checks…
…jections Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
quic-rishinr
requested changes
Apr 10, 2025
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
quic-rishinr
requested changes
Apr 11, 2025
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
ochougul
requested changes
Apr 18, 2025
Signed-off-by: eplatero <[email protected]>
Signed-off-by: Erick Platero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Loading status checks…
Signed-off-by: eplatero <[email protected]>
Signed-off-by: Erick Platero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Signed-off-by: eplatero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This PR seeks to implement post-attention hidden size projections used to speculate tokens ahead of the base model. This PR contains three primary components:
modeling_auto.py
Initial Implementation
Initial implementation gives the user the flexibility to define its own projection architecture and pass it to
QEffAutoModelForCausalLM
.Then, QEfficient simply attaches these projections to the model to be used during the forward pass. The "attaching" of these projections is done by using the
accelerate
library. I used this library because it has a robust implementation to attach weights to an already existing model. We can implement our own abstraction if needed, but first we must agree on what the external API will be to the user.