-
Couldn't load subscription status.
- Fork 22
feat: support decimal #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RaphDal
wants to merge
68
commits into
main
Choose a base branch
from
rd_decimal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
9096533
feat: add decimal support to buffer
RaphDal 74f6f62
docs: add decimal in rust examples
RaphDal 3c87c76
docs: improve doc for decimal
RaphDal 2883ea2
fix: restrict visibility of must_escape_unquoted to the crate only
RaphDal 457b77a
fix: improve binary compatibility check
RaphDal 3d8645b
fix: satisfy clippy with feature-gated usage of DECIMAL_BINARY_FORMAT…
RaphDal 139e92d
docs: set diagram comment as text
RaphDal 4bf9bfc
docs: removed unnecessary comment
RaphDal 17f699b
docs: fix comment typo
RaphDal a583839
docs: fix buffer decimal examples
RaphDal c7f19af
feat: added support for C and C++
RaphDal 6cc4237
fix: add missing error codes to C and C++ headers
RaphDal 4aa3b14
fix: update type hints to include decimal in python test
RaphDal fb8ac1e
ci: trigger
RaphDal 2095903
tests: add decimal support to ilp-client-interop-test
RaphDal 984a236
feat: improve cpp decimal integration to cpp
RaphDal ce0fe17
typo: fix invalid comments
RaphDal d2ee26c
feat: add protocol version 3
RaphDal 4c4b9af
revert: revert removal of implicit coercion of decimal binary views
RaphDal 4a6a07c
feat: generalize array customization point
RaphDal cf425b5
typo: remove garbage
RaphDal 2180a9f
docs: remove no longer true comment
RaphDal 14b54eb
feat: improved decimal string validation
RaphDal fe7cceb
feat: add customization point for decimal
RaphDal 44fe751
fix: accept more characters in decimal serializer for str to allow na…
RaphDal 1b69994
tests: update test to use protocol version 3
RaphDal 36f534e
docs: add decimal to c/cpp docs
RaphDal b11912a
tests: update rust examples to use protocol version 3
RaphDal 147bab4
feat: add protocol version 3 to supported protocol versions
RaphDal 77520ef
docs: add a simple description about the decimal datatype to ingress
RaphDal d9ef50d
fix: change port variable type to String for consistency
RaphDal 6d19bd9
fix: change to_array_view_state_impl argument to const reference
RaphDal f47ee4f
fix: update usage message to line_sender_c_example_decimal_custom
RaphDal 23d51b2
fix: remove unused includes from line_sender_array.hpp
RaphDal 1f889e7
fix: update scale validation in DecimalSerializer to allow negative s…
RaphDal 466b26d
fix: update protocol version to v3 in line_sender tests and header
RaphDal 8dad866
fix: remove unused price_value assignment in line_sender_c_example_de…
RaphDal de1bba3
fix: update usage message to reflect correct example name in line_sen…
RaphDal 12882be
fix: update price column type and correct table name in protocol_vers…
RaphDal cf1dd4d
Merge branch 'main' into rd_decimal
RaphDal f1624df
fix: free line sender buffer after flushing in example files
RaphDal 9d564a8
fix: qualify binary_view with questdb::ingress::decimal namespace
RaphDal e63da89
fix: update protocol version to 2 in line sender examples
RaphDal ed83ff2
fix: update protocol version checks to use comparison operators
RaphDal ed7a984
fix: add PartialOrd to ProtocolVersion
RaphDal 727cf09
fix: rename binary_view to decimal_view in decimal namespace
RaphDal d730bad
fix: remove supports method from ProtocolVersion implementation
RaphDal e6140e3
fix: clarify error messages for decimal scale and byte length limits
RaphDal 1ebc6e6
typo: add missing definite article in ingress documentation
RaphDal 0764846
fix: expose decimal_view in line_sender.hpp
RaphDal e2fa211
fix: cast ProtocolVersion to u8 for comparison in json_tests
RaphDal 3bc2e3a
refactor: split headers
RaphDal 17f2427
fix: improve error message for unsupported client protocol version
RaphDal af76951
Merge branch 'main' into rd_decimal
RaphDal 9489414
fix: clarify implementation details for DecimalSerializer
RaphDal ba6744c
fix: correct wording in protocol version documentation for clarity
RaphDal 61f16a7
fix: improve error messages for decimal scale and value length constr…
RaphDal 61ff7ec
fix: correct order of fields in binary serialization format documenta…
RaphDal 59cb32e
Merge branch 'main' into rd_decimal
RaphDal b2cedfd
fix: handle null data in line_sender_buffer_column_dec function
RaphDal 1ede6d7
fix: remove debug output for protocol version in SenderBuilder
RaphDal e86a18d
fix: update usage message to include program name in help output
RaphDal 5b17715
fix: use http instead of tcp in decimal examples
RaphDal 76104aa
refactor: replace DecimalSerializer with DecimalView
RaphDal fec2164
test: add tests for NaN and Infinity decimal representations
RaphDal dfb9fd4
fix: correct spelling of 'Infinity' in validation comments
RaphDal 23329b0
fix: improve error message for invalid decimal strings
RaphDal 73d9f0d
fix: correct scale type in DecimalView conversion
RaphDal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.