add -generate-vanity-address feature #112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krypdkat
reviewed
Jan 13, 2026
wallet_utils.cpp
Outdated
| thread_local std::uniform_int_distribution<int> dist(0, sizeof(charset) - 2); | ||
| std::string str(55, 0); | ||
| for (size_t i = 0; i < 55; ++i) { | ||
| str[i] = charset[dist(gen)]; |
Contributor
There was a problem hiding this comment.
it's best practice to use rd() here (from std::random_device) . std::mt19937 is considered unsafe for seed generator.
krypdkat
reviewed
Jan 13, 2026
| auto currentTime = std::chrono::high_resolution_clock::now(); | ||
| auto durationSinceLastPrint = std::chrono::duration_cast<std::chrono::seconds>(currentTime - lastPrintTime).count(); | ||
| if (durationSinceLastPrint >= 1) { | ||
| lastPrintTime = currentTime; |
Contributor
There was a problem hiding this comment.
This can have data-race, if possible, just do the print on thread #0 only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-generate-vanity-address <EXPECTED_CHARS> <IS_SUFIX>
Generates a vanity address matching the expected characters using multiple threads, with an option to match as a suffix.
Example: ./qubic-cli -generate-vanity-address ABC 1 false (will generate an address starting with ABC)
./qubic-cli -generate-vanity-address XYZ 4 true (will generate an address ending with XYZ using 4 threads)