Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urn: add URN parser and helpers #1323

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Apr 16, 2024

This sets up some support infrastructure to unify naming across claircore. The goal is to be able to pass around names as strings instead of interface objects.

I'm unsure about the Name type -- thoughts on if that should live here and if it should get a method on URN?

This sets up some support infrastructure to unify naming across
claircore. The goal is to be able to pass around names as strings
instead of interface objects.

Signed-off-by: Hank Donnay <[email protected]>
@hdonnay hdonnay requested a review from a team as a code owner April 16, 2024 15:04
@hdonnay hdonnay requested review from crozzy and removed request for a team April 16, 2024 15:04
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 56.01%. Comparing base (e8f9aff) to head (e26ece1).

Files Patch % Lines
toolkit/urn/urn.go 87.32% 5 Missing and 4 partials ⚠️
toolkit/urn/escape.go 92.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1323      +/-   ##
==========================================
+ Coverage   55.76%   56.01%   +0.24%     
==========================================
  Files         265      268       +3     
  Lines       16562    16672     +110     
==========================================
+ Hits         9236     9339     +103     
- Misses       6365     6369       +4     
- Partials      961      964       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hdonnay
Copy link
Member Author

hdonnay commented Apr 16, 2024

Re-drafting this until I figure out what to do about percent-encoding.

@hdonnay hdonnay marked this pull request as draft April 16, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant