Extract DPEs that are instantiated from mixed design/config servers #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasxos
reviewed
Aug 21, 2024
One example: every AMAC chip has 4 GaNFETs to control different high-voltage channels. We would like to model each switch as its own object in the OPC server. They should be children of AMAC objects --- the AMAC objects are configuration-instantiated. However, the switch objects are identical across AMACs, and can therefore be design-instantiated. |
Previously, if a configuration-instantiated object had children that were instantiated from design, Cacophony would not generate any code to parse those children. This commit updates the `designToConfigParser` template to parse design-instantiated children of configuration-instantiated objects. It does so by separating the XML-dependent part of DPE creation from the XML-independent part, and parsing the design for the XML-independent part.
Benkendorfer
force-pushed
the
dpesFromDesign
branch
from
63cfe20 to
0315c4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there were options to run Cacophony over servers that are purely instantiated from design, and servers that are purely instantiated from config. This PR adds logic to handle the case where some configuration-instantiated objects
The change was based originally from tag
until_quasar_1.5.12Addresses corresponding issue https://its.cern.ch/jira/browse/OPCUA-3178