Repository navigation
Allow ::: without preceding empty line to be parsed as closing div - #875
Merged
Merged
Conversation
jkrumbiegel
changed the title
::: without preceding empty line to be parsed as closing div
juliasilge
approved these changes
Jan 2, 2026
juliasilge
left a comment
juliasilge
left a comment
Collaborator
There was a problem hiding this comment.
Thank you so much, @jkrumbiegel! I added a few tests and updated the CHANGELOG; we can wait for @vezwork to take a look next week before merging.
Super glad that you dug into this! 🙌
vezwork
approved these changes
Jan 6, 2026
Member
There was a problem hiding this comment.
I read the issue. I looked at the fix. I read the markdownit docs a bit, I still don't totally understand the fix, but it sounds good that it resolves all the code block problems from the issue. I ran the tests locally and looked at the test code and test qmd file and it looks great. Nice work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #521
I dug into this issue (with the help of Claude) and it turned out that the div plugin didn't see the closing
:::fences at all. So in principle what all the downstream code got was a huge nested structure of divs, never getting closed. This could then swallow up code blocks, making them appear just as normal markdown paragraphs and not executable ones (they never even got registered as code blocks). Apparently addingparagraphto div'saltentry lets:::without preceding newlines be matched as div fences again instead of paragraph content. For me this fixed all of the examples I could try from #521 (except the as I now understand unrelated math one with inline$$).