Fix theme updating when VS Code auto theme detection is on #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add notification system to send actual theme kind from VS Code to LSP - Track active color theme kind in LSP ConfigurationManager - Send theme notifications on startup and when theme changes - Use actual theme kind instead of parsing theme name Co-authored-by: kv9898 <[email protected]>
- Add explicit check for 'Dark' in theme name fallback - Only fire configuration change event if theme actually changed Co-authored-by: kv9898 <[email protected]>
- Add validation for theme kind parameter in notification handler - Document HighContrast theme handling (treated as dark) - Prevent fallback detection from overriding explicit theme notifications - Add flag to track whether theme was explicitly set Co-authored-by: kv9898 <[email protected]>
Collaborator
Author
Thanks! I understand that Quarto is highly modularized and communication between parts can be tricky (and debugging quarto is definitely not easy from my experience). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #861
I admit the fix is a bit ugly and I wish better solutions are possible.