Handle keep-ipynb correctly now that fileInformationCache is responsible for the cleaning #12793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first proposal to fix #12780
It is based on the fact that
quarto inspect
#12337 introduced a globalfileInformationCache
in the project context, that does the cleaning. Forquarto inspect
but also forquarto render
- without taking into accountkeep-ipynb
So this PR does now in
execute()
settransient: false
to prevent cleaning whenkeep-ipynb: true
The cleaning is still done by fileInformationCache cleanup step.
To ensure that happens, the
safeCloneDeep
escape mode is leveraged to ensure that the project contextfileInformationCache
will always be accessible by reference.I said first proposal because there is supposed to be a cleaning mechanism in engine with
executeTargetSkipped
and so I don't see why #12337 was requiring this fileInformationCache cleanup.