Skip to content

Handle keep-ipynb correctly now that fileInformationCache is responsible for the cleaning #12793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented May 21, 2025

This is a first proposal to fix #12780

It is based on the fact that

So this PR does now in execute() set transient: false to prevent cleaning when keep-ipynb: true

The cleaning is still done by fileInformationCache cleanup step.

To ensure that happens, the safeCloneDeep escape mode is leveraged to ensure that the project context fileInformationCache will always be accessible by reference.

I said first proposal because there is supposed to be a cleaning mechanism in engine with
executeTargetSkipped and so I don't see why #12337 was requiring this fileInformationCache cleanup.

@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented May 21, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keep-ipynb does not keep notebook
2 participants