-
Notifications
You must be signed in to change notification settings - Fork 352
tests environment - update to latest Python packages #12753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Some package updates are making some test fail 😞 This post follows the investigation No more width and height on figuresupdate made crossref structure change 🤔
::: {#cell-fig-plot .cell execution_count=1}
::: {.cell-output .cell-output-display}
{#fig-plot width=789 height=411}
:::
::: Is this expected ? This creates the difference In HTML it renders to <div id="cell-fig-plot" class="cell" data-execution_count="1">
<div class="cell-output cell-output-display">
<div id="fig-plot" class="quarto-float quarto-figure quarto-figure-center anchored">
<figure class="quarto-float quarto-float-fig figure">
<div aria-describedby="fig-plot-caption-0ceaefa1-69ba-4598-a22c-09a6ac19f8ca">
<img src="surus.png" class="img-fluid figure-img">
</div>
<figcaption class="quarto-float-caption-bottom quarto-float-caption quarto-float-fig" id="fig-plot-caption-0ceaefa1-69ba-4598-a22c-09a6ac19f8ca">
Figure 1: Plot
</figcaption>
</figure>
</div>
</div>
</div> but in Revealjs, we loose quarto-float because of post process for <img data-src="surus.png" class="r-stretch quarto-figure-center" id="fig-plot"><p class="caption">
Figure 1: Plot
</p> quarto-cli/src/format/reveal/format-reveal.ts Lines 1033 to 1039 in 95839d2
Probably not looking at the code quarto-cli/src/resources/jupyter/lang/python/setup.py Lines 18 to 27 in 95839d2
I notice by the way that the function we use for the format has been deprecated for a few versions, and is now removed |
This PR follows the one about R deps.