Skip to content

tests environment - update to latest Python packages #12753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented May 16, 2025

This PR follows the one about R deps.

  • Update uv version
  • Update python to 3.13.2
  • Update all packages in lock file

@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented May 16, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@cderv cderv force-pushed the update-uv-pkgs branch from f4fbd05 to 95839d2 Compare May 19, 2025 14:44
@cderv
Copy link
Collaborator Author

cderv commented May 20, 2025

Some package updates are making some test fail 😞

This post follows the investigation

No more width and height on figures

update made crossref structure change 🤔

width and height are no more set in the intermediate md like here

::: {#cell-fig-plot .cell execution_count=1}

::: {.cell-output .cell-output-display}
![Plot](surus.png){#fig-plot width=789 height=411}
:::
:::

Is this expected ? This creates the difference

In HTML it renders to

<div id="cell-fig-plot" class="cell" data-execution_count="1">
<div class="cell-output cell-output-display">
<div id="fig-plot" class="quarto-float quarto-figure quarto-figure-center anchored">
<figure class="quarto-float quarto-float-fig figure">
<div aria-describedby="fig-plot-caption-0ceaefa1-69ba-4598-a22c-09a6ac19f8ca">
<img src="surus.png" class="img-fluid figure-img">
</div>
<figcaption class="quarto-float-caption-bottom quarto-float-caption quarto-float-fig" id="fig-plot-caption-0ceaefa1-69ba-4598-a22c-09a6ac19f8ca">
Figure&nbsp;1: Plot
</figcaption>
</figure>
</div>
</div>
</div>

but in Revealjs, we loose quarto-float because of post process for auto-stretch

<img data-src="surus.png" class="r-stretch quarto-figure-center" id="fig-plot"><p class="caption">
Figure&nbsp;1: Plot
</p>

// add stretch class if not already when auto-stretch is set
if (
autoStretch === true &&
!hasStretchClass(imageEl) &&
// if height is already set, we do nothing
!imageEl.getAttribute("style")?.match("height:") &&
!imageEl.hasAttribute("height") &&

Is this expected ?

Probably not looking at the code

# matplotlib defaults / format
try:
import matplotlib.pyplot as plt
plt.rcParams['figure.figsize'] = (fig_width, fig_height)
plt.rcParams['figure.dpi'] = fig_dpi
plt.rcParams['savefig.dpi'] = "figure"
from IPython.display import set_matplotlib_formats
set_matplotlib_formats(fig_format)
except Exception:

I notice by the way that the function we use for the format has been deprecated for a few versions, and is now removed

@cderv cderv marked this pull request as draft May 20, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants