Repository navigation
Fix stale useEffect deps (bd-lsf2v5n0) - #924
Merged
Merged
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
- Re-seed screen name when auth resolves after the initial load - Clear the offline banner when the connection is restored - Restore select-all when the share dialog opens, and clean up its timer - Replace four exhaustive-deps suppressions with honest deps; document three Phase 1 of claude-notes/plans/2026-10-24-hub-client-useeffect-refactor.md.
shikokuchuo
force-pushed
the
bugfix/bd-lsf2v5n0-useeffect-phase1
branch
from
October 27, 2026 11:37
1e4de9d to
3d8286f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 of
claude-notes/plans/2026-10-24-hub-client-useeffect-refactor.md(bd-lsf2v5n0). Phase 2 is stacked on this branch: #925.App.tsx).connectionError. Extracted toservices/connectionHandlers.tsas the smallest testable seam.exhaustive-depssuppressions with honest deps; document why the remaining three stay.The banner and select-all fixes are user-facing and have a changelog entry.
Tests: full
npm run test:ciandnpm run buildgreen. Each fix landed with a regression test watched red first. Not verified in a real browser session.