Skip to content

OpenTelemetry exporters documentation improvements #48580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Jun 24, 2025

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the value is not supported, we should update the config to indicate that and also provide a good error message

Copy link

quarkus-bot bot commented Jun 24, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit d70708e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link

🎊 PR Preview 18d8e42 has been successfully built and deployed to https://quarkus-pr-main-48580-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@spio
Copy link

spio commented Jun 25, 2025

Hi, Bruno.

It seems good to me.

I would suggest some more changes to the docs:

  • In the description of the "quarkus.otel.traces.exporter" property (under both titles "OpenTelemetry Configuration Reference" and "Disable all or parts of the OpenTelemetry extension"), I think that the "otlp" option shoud be removed as a valid value, because it is not.
  • By removing that value, the new section "The OpenTelemetry OTLP exporter" it's not necessary; in fact, it seems too severe to me to say "This is currently not supported in quarkus"; perhaps stating that "this is used by default in Quarkus" instead of that sentence is a little more polite.
  • I think that adding a quick link to database tracing there could be useful.

And one last thing, but it is not fully related to this: it seems strange to me that, by default, direct jdbc connections are not traced by default (i.e. quarkus.datasource.jdbc.telemetry=false), but reactive connections are (quarkus.otel.instrument.vertx-sql-client=true). By the way, if you can, I would suggest to also modify the Quarkus Datasource config docs (https://es.quarkus.io/guides/datasource) to show, under the "Datasource tracing" title, that each datasource can be configured using "quarkus.datasource..jdbc.telemetry=true", as it is shown under "Datasource health check", "Datasource metrics" and "Narayana transaction manager integration".

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants