Skip to content

Add Jakarta Data documentation, dependency management and tests #47012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marko-bekhta
Copy link
Contributor

@marko-bekhta marko-bekhta commented Mar 26, 2025

fixes #44278

I wasn't sure if we should just add the tests to the hibernate-orm-jpamodelgen hence.. I kept the one in the new module as close to the hibernate-orm-jpamodelgen so that if we decide to merge them in that module, it'll be easier.

I've tested the config for the gradle doc example on a test project and this bit:

annotationProcessor enforcedPlatform("${quarkusPlatformGroupId}:${quarkusPlatformArtifactId}:${quarkusPlatformVersion}")

seems to help with the version management for the AP in the Gradle case.

A quickstart draft PR is here: quarkusio/quarkus-quickstarts#1516

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/docstyle issues related for manual docstyle review area/documentation labels Mar 26, 2025

This comment has been minimized.

Copy link

github-actions bot commented Mar 26, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@geoand geoand requested review from yrodiere and FroMage March 27, 2025 07:43
@marko-bekhta marko-bekhta force-pushed the feat/i44278-add-jakarta-data-tests branch from 3eb68a0 to b4493ca Compare March 27, 2025 14:30

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer approuval to @yrodiere

@FroMage FroMage requested a review from gsmet March 28, 2025 14:44
@marko-bekhta marko-bekhta force-pushed the feat/i44278-add-jakarta-data-tests branch from b4493ca to e2690a8 Compare March 28, 2025 15:13

This comment has been minimized.

This comment has been minimized.

@marko-bekhta marko-bekhta force-pushed the feat/i44278-add-jakarta-data-tests branch from e2690a8 to 0f15ddc Compare April 2, 2025 16:17

This comment has been minimized.

This comment has been minimized.

@yrodiere yrodiere changed the title Add Jakarta Data dependency management and tests Add Jakarta Data documentation, dependency management and tests Apr 8, 2025
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer approuval to @yrodiere

A few comments below, but I'm approuving. Thank you!
Feel free to address what you agree with, then let's merge.

Baguette, omelette au fromage.

@marko-bekhta marko-bekhta force-pushed the feat/i44278-add-jakarta-data-tests branch from 0f15ddc to cc55044 Compare April 11, 2025 12:13
@marko-bekhta
Copy link
Contributor Author

thanks 😃
rebased and applied the changes.

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 11, 2025
Copy link

quarkus-bot bot commented Apr 11, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit cc55044.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Apr 11, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit cc55044.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@yrodiere yrodiere merged commit f071db3 into quarkusio:main Apr 14, 2025
59 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.22 - main milestone Apr 14, 2025
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Apr 14, 2025
@yrodiere yrodiere added release/noteworthy-feature triage/waiting-for-ci Ready to merge when CI successfully finishes labels Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/docstyle issues related for manual docstyle review area/documentation kind/enhancement New feature or request release/noteworthy-feature triage/flaky-test triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JPA static metamodel / Jakarta Data tests, dependency management and documentation
4 participants