-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support one-time authorization code for form-based authentication mechanism #46974
base: main
Are you sure you want to change the base?
Support one-time authorization code for form-based authentication mechanism #46974
Conversation
michalvavrik
commented
Mar 24, 2025
•
edited
Loading
edited
- Implements non-JDBC part of the Enhance Form authentication to support one-time tokens #45977.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Update: Windows failure seems like a bug (though don't see how it is related to changes here), I'll find it and fix it. |
Oh, it is failing because during merging I removed the fix I introduced to Quarkus main branch already, my bad, I'll drop it. |
Thanks @michalvavrik, I'll look a bit later. |
7c7b6b6
to
6db6efa
Compare
Thanks as well, no hurry, I expect this will take a longer discussion. But I think it is easier this way because it is less code to review and once this is in, JDBC part will be easy. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
...spi/src/main/java/io/quarkus/security/spi/runtime/OneTimeAuthZCodeAuthenticationRequest.java
Outdated
Show resolved
Hide resolved
...ns/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/FormAuthRuntimeConfig.java
Outdated
Show resolved
Hide resolved
@michalvavrik Thanks, I've started commenting and we can continue in the next few days, I suggest to set it Draft for now as I guess there will be a few more iterations |
As the PR is draft now, I'll be pushing changes continuously. I'll inform you with a PR comment once the PR is adapted to what we agreed in here and via email. Please ignore pushes until then. |
6db6efa
to
fff3113
Compare
fff3113
to
dbfe323
Compare