Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support one-time authorization code for form-based authentication mechanism #46974

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Mar 24, 2025

@michalvavrik michalvavrik requested a review from sberyozkin March 24, 2025 23:21
@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation area/security area/vertx labels Mar 24, 2025

This comment has been minimized.

Copy link

github-actions bot commented Mar 25, 2025

😭 Deploy PR Preview failed.

This comment has been minimized.

@michalvavrik
Copy link
Member Author

michalvavrik commented Mar 25, 2025

Update: Windows failure seems like a bug (though don't see how it is related to changes here), I'll find it and fix it.

@michalvavrik
Copy link
Member Author

Oh, it is failing because during merging I removed the fix I introduced to Quarkus main branch already, my bad, I'll drop it.

@sberyozkin
Copy link
Member

Thanks @michalvavrik, I'll look a bit later.

@michalvavrik michalvavrik force-pushed the feature/form-auth-one-time-token branch from 7c7b6b6 to 6db6efa Compare March 25, 2025 11:51
@michalvavrik
Copy link
Member Author

Thanks @michalvavrik, I'll look a bit later.

Thanks as well, no hurry, I expect this will take a longer discussion. But I think it is easier this way because it is less code to review and once this is in, JDBC part will be easy.

This comment has been minimized.

This comment has been minimized.

@sberyozkin
Copy link
Member

@michalvavrik Thanks, I've started commenting and we can continue in the next few days, I suggest to set it Draft for now as I guess there will be a few more iterations

@michalvavrik michalvavrik marked this pull request as draft March 25, 2025 17:51
@michalvavrik
Copy link
Member Author

As the PR is draft now, I'll be pushing changes continuously. I'll inform you with a PR comment once the PR is adapted to what we agreed in here and via email. Please ignore pushes until then.

@michalvavrik michalvavrik force-pushed the feature/form-auth-one-time-token branch from 6db6efa to fff3113 Compare March 26, 2025 14:07
@michalvavrik michalvavrik force-pushed the feature/form-auth-one-time-token branch from fff3113 to dbfe323 Compare March 29, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants