-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting Clear-Site-Data on OIDC logout #46864
Allow setting Clear-Site-Data on OIDC logout #46864
Conversation
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/OidcTenantConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a typo, but looks okay to me
42b8141
to
66ba054
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
66ba054
to
a04e211
Compare
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
Hmm, I'm afraid this is the test I added that is flaky, sorry about that, let me fix it |
a04e211
to
9a623b4
Compare
Status for workflow
|
Status for workflow
|
OK, let me merge since 2 approvals are available, thanks |
Fixes #46723.
This simple PR allows OIDC users to choose to send one or more Clear-Site-Data directives after the logout request. Even though the PR is simple, I added a
release/noteworthy-feature
label to draw some attention to it sinceClear-Site-Data
is a rather new HTTP response header but which can be rather useful.Also, this PR is done as part of the threat modelling activity.
I also did some minor, test-level only updates to fix a few logout constant names