Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting Clear-Site-Data on OIDC logout #46864

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Mar 18, 2025

Fixes #46723.

This simple PR allows OIDC users to choose to send one or more Clear-Site-Data directives after the logout request. Even though the PR is simple, I added a release/noteworthy-feature label to draw some attention to it since Clear-Site-Data is a rather new HTTP response header but which can be rather useful.
Also, this PR is done as part of the threat modelling activity.

I also did some minor, test-level only updates to fix a few logout constant names

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo, but looks okay to me

@sberyozkin sberyozkin force-pushed the oidc_logout_clear_site_data branch from 42b8141 to 66ba054 Compare March 18, 2025 13:41

This comment has been minimized.

This comment has been minimized.

@sberyozkin sberyozkin force-pushed the oidc_logout_clear_site_data branch from 66ba054 to a04e211 Compare March 18, 2025 14:31

This comment has been minimized.

Copy link

github-actions bot commented Mar 18, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@sberyozkin
Copy link
Member Author

Hmm, I'm afraid this is the test I added that is flaky, sorry about that, let me fix it

@sberyozkin sberyozkin force-pushed the oidc_logout_clear_site_data branch from a04e211 to 9a623b4 Compare March 18, 2025 17:39
Copy link

quarkus-bot bot commented Mar 18, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 9a623b4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Mar 18, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9a623b4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin
Copy link
Member Author

OK, let me merge since 2 approvals are available, thanks

@sberyozkin sberyozkin merged commit e2ec7c1 into quarkusio:main Mar 18, 2025
30 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.22 - main milestone Mar 18, 2025
@sberyozkin sberyozkin deleted the oidc_logout_clear_site_data branch March 18, 2025 18:58
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow sending HTTP Clear-Site-Data after OIDC logout
3 participants