Add checks around marshal.load
#1174
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to address [code scanning alert quantumlib#567]( https://github.com/quantumlib/OpenFermion/security/code-scanning/567) about unsafe deserialization of user-provided data. This adds some checking around the unmarshaling of stored operators.
pavoljuhas
reviewed
Nov 26, 2025
Contributor
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
The marshal.load call is inherently insecure and as such it cannot be fixed by post-call checks.
We can either leave it as is and require that load_operator is used only on trusted data (ie, update docstring) OR deprecate and eventually remove loading of marshal files and only allow the plain_text format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address code scanning alert #567 about unsafe deserialization of user-provided data. This adds some checking around the unmarshaling of stored operators.