Skip to content

Ignore isort code formatting in git blame #7197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

Ignore isort code formatting in git blame #7197

merged 1 commit into from
Mar 28, 2025

Conversation

pavoljuhas
Copy link
Collaborator

Finalizes #7195

@pavoljuhas pavoljuhas requested review from vtomole and a team as code owners March 28, 2025 03:40
@pavoljuhas pavoljuhas enabled auto-merge March 28, 2025 03:43
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (250f129) to head (97e5a28).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7197      +/-   ##
==========================================
- Coverage   98.14%   98.14%   -0.01%     
==========================================
  Files        1100     1100              
  Lines       96147    96147              
==========================================
- Hits        94366    94364       -2     
- Misses       1781     1783       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mhucka
mhucka approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@pavoljuhas pavoljuhas added this pull request to the merge queue Mar 28, 2025
mhucka
mhucka approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Merged via the queue into quantumlib:main with commit d23f24a Mar 28, 2025
39 checks passed
@pavoljuhas pavoljuhas deleted the no-blame-for-isort-formatting branch March 28, 2025 17:31
@mhucka mhucka mentioned this pull request Apr 18, 2025
Merged
This was referenced May 30, 2025
Merged
Merged
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
@pavoljuhas @BichengYing
Ignore isort code formatting in git blame (quantumlib#7197)
a1c1ce8 
Finalizes quantumlib#7195
@NoureldinYosri NoureldinYosri mentioned this pull request Aug 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhucka mhucka mhucka approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@95-martin-orion 95-martin-orion Awaiting requested review from 95-martin-orion 95-martin-orion is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavoljuhas @mhucka