Merge pull request #362 from probablyup/remove-unused-rule

remove redundant HTML comment removal, do not strip inside code blocks

index.compiler.spec.tsx

@@ -2830,6 +2830,28 @@ describe('fenced code blocks', () => {
       </pre>
     `)
   })
+
+  it('should not strip HTML comments inside fenced blocks', () => {
+    render(
+      compiler(
+        `
+\`\`\`html
+<!-- something -->
+Yeah boi
+\`\`\`
+`.trim()
+      )
+    )
+
+    expect(root.innerHTML).toMatchInlineSnapshot(`
+      <pre>
+        <code class="lang-html">
+          &lt;!-- something --&gt;
+      Yeah boi
+        </code>
+      </pre>
+    `)
+  })
 })
 
 describe('indented code blocks', () => {

index.tsx

@@ -300,7 +300,7 @@ const HTML_BLOCK_ELEMENT_R = /^ *(?!<[a-z][^ >/]* ?\/>)<([a-z][^ >/]*) ?([^>]*)\
 
 const HTML_CHAR_CODE_R = /&([a-z]+);/g
 
-const HTML_COMMENT_R = /^<!--.*?-->/
+const HTML_COMMENT_R = /^<!--[\s\S]*?(?:-->)/
 
 /**
  * borrowed from React 15(https://github.com/facebook/react/blob/894d20744cba99383ffd847dbd5b6e0800355a5c/src/renderers/dom/shared/HTMLDOMPropertyConfig.js)
@@ -837,9 +837,9 @@ function parseBlock(parse, content, state): MarkdownToJSX.ParserResult {
   return parse(content + '\n\n', state)
 }
 
-const parseCaptureInline: MarkdownToJSX.Parser<ReturnType<
-  typeof parseInline
->> = (capture, parse, state) => {
+const parseCaptureInline: MarkdownToJSX.Parser<
+  ReturnType<typeof parseInline>
+> = (capture, parse, state) => {
   return {
     content: parseInline(parse, capture[1], state),
   }
@@ -1032,10 +1032,6 @@ export function compiler(
       : undefined
   }
 
-  function stripHtmlComments(html) {
-    return html.replace(/<!--[\s\S]*?(?:-->)/g, '')
-  }
-
   /* istanbul ignore next */
   if (process.env.NODE_ENV !== 'production') {
     if (typeof markdown !== 'string') {
@@ -1797,7 +1793,7 @@ export function compiler(
   const parser = parserFor(rules)
   const emitter: Function = reactFor(ruleOutput(rules))
 
-  const jsx = compile(stripHtmlComments(markdown))
+  const jsx = compile(markdown)
 
   if (footnotes.length) {
     jsx.props.children.push(