Repository navigation
fix(security): resolve CodeQL findings in untrusted-input paths - #30
Merged
Merged
Conversation
- qprobe/mlkem768: replace biased modulo sampling with unbiased rejection sampling for the throwaway probe key (js/biased-cryptographic-random) - sieve/protocol fromB64: replace the /=+$/ trailing-trim (O(n^2) on the untrusted SUT response) with a linear scan (js/polynomial-redos) - mcp/http: disambiguate the Bearer regex (\S.* instead of .+) so the auth header parse can't backtrack (js/polynomial-redos) All 216 tests pass, including the property-based fuzz tests on the patched parsers. Trailing-slash trims on trusted config input (walk globs, agent baseURL) are dismissed separately as not attacker-controlled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CodeQL findings that sit on attacker-controlled input:
fromB64(parses untrusted system-under-test output) and MCP bearer-token parsing (untrusted auth header): both O(n^2) regexes replaced with linear equivalents.216 tests pass, including the fuzz tests on the patched parsers. The remaining trailing-slash-trim findings (walk glob patterns, agent baseURL) are on trusted config input and are dismissed separately.