fix: current_conditions SFI/Kp/Bz unavailable (SWPC JSON format drift)#4
Open
KI7MT wants to merge 1 commit into
Open
fix: current_conditions SFI/Kp/Bz unavailable (SWPC JSON format drift)#4KI7MT wants to merge 1 commit into
KI7MT wants to merge 1 commit into
Conversation
… format changes - Same root cause as solar-mcp #3: noaa.py parsing assumed old dict/list-of-lists shapes for /10cm-flux.json, /noaa-planetary-k-index.json, /solar-wind-mag-field.json. - Updated to handle current list-of-dicts + legacy. - Now SFI/Kp/Bz populate correctly in propagation reports. - Added to Unreleased in CHANGELOG. Verified via direct client call: sfi=128, kp=0.67, no errors. Closes: related to solar-mcp issue. Co-Authored-By: Grok (xAI)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
ionis__current_conditions(and derived band outlooks in propagation reports) returning "unavailable" for SFI, Kp, Bz due to NOAA SWPC changing the JSON response formats on the endpoints used byfetch_current_conditionsinnoaa.py.This is the same root cause as the solar-mcp issue (see qso-graph/solar-mcp#3 and #4).
Changes
src/ionis_mcp/noaa.pyfor current list-of-dicts (and legacy) for:Verification
Impact
Closes #3
Co-Authored-By: Grok (xAI)