fix(server): drop hardcoded enum count from list_enumerations docstring (#5)#7
Closed
KI7MT wants to merge 1 commit into
Closed
fix(server): drop hardcoded enum count from list_enumerations docstring (#5)#7KI7MT wants to merge 1 commit into
KI7MT wants to merge 1 commit into
Conversation
…ng (#5) Docstring claimed '25 ADIF 3.1.7 enumerations' but the function returns 26 (test_list_enumerations_count asserts 26). Removed the hardcoded number so it can't drift again. Docstring-only; no logic change. test/test_enumerations.py green (62 passed). Drafted autonomously by Daina (local qwen3-coder via qwen-code), verified by Bob. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Closing as a duplicate of #6, which makes the identical one-line docstring fix and also includes the CHANGELOG entry this PR is missing. Both close #5; #6 is the more complete artifact. (This PR was a same-fix re-do of an already-open week-old PR — keeping #6 to avoid the redundant merge.) Verification notes here remain on the thread for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5.
Change: one-line docstring fix in
list_enumerations()— removes the hardcoded "25" (function actually returns 26;test_list_enumerations_countasserts 26). No logic change.Verification:
test/test_enumerations.py→ 62 passed. (test_cli_test.pycollection error is pre-existing on main — missingcli_test_helperstest dep, unrelated.)Pilot note: drafted autonomously by Daina (local qwen3-coder via qwen-code, on 9975) from a spec + test-oracle, iterated to green on her own; Bob verified the diff independently (control point). Draft — 3-panel review still owed before merge; merge stays with Judge.