-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keyboard] Add Marcopad #24636
Merged
Merged
[Keyboard] Add Marcopad #24636
+176
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
requested changes
Nov 23, 2024
dunk2k
suggested changes
Nov 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Community Layout support
marcopelegrini
force-pushed
the
users/mpelegrini/Marcopad
branch
from
November 24, 2024 03:11
825b52e
to
72dda14
Compare
dunk2k
suggested changes
Nov 24, 2024
marcopelegrini
force-pushed
the
users/mpelegrini/Marcopad
branch
from
November 24, 2024 16:21
565371f
to
73fea49
Compare
waffle87
reviewed
Dec 2, 2024
drashna
approved these changes
Dec 4, 2024
waffle87
approved these changes
Dec 4, 2024
pull bot
pushed a commit
to kruton/qmk_firmware
that referenced
this pull request
Dec 4, 2024
* Marcopad debut * Applying core review suggestions * Optional layout with backlit * Line feeds and replacing dev board configs * Function to toggle backlight * Move to RGB Matrix * Fixing capitalization * Review comments --------- Co-authored-by: Marco Pelegrini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Marcopad
Types of Changes
Issues Fixed or Closed by This PR
Checklist