Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cans12erv2 #24628

Merged
merged 12 commits into from
Dec 4, 2024
Merged

Add support for cans12erv2 #24628

merged 12 commits into from
Dec 4, 2024
+94 −0

Conversation

canbaytok
Copy link
Contributor

@canbaytok canbaytok commented Nov 21, 2024 •
edited
Loading

Description

I've worked on a new version of my small handwired DIY keypad, which now features hot swap switch sockets and an encoder knob.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 reviewed Nov 21, 2024
View reviewed changes
keyboards/handwired/cans12erv2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/cans12erv2/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/cans12erv2/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/cans12erv2/readme.md Outdated Show resolved Hide resolved
@drashna drashna merged commit c2bc6e2 into qmk:master Dec 4, 2024
3 checks passed
@canbaytok canbaytok deleted the cans12erv2 branch December 4, 2024 16:41
pull bot pushed a commit to kruton/qmk_firmware that referenced this pull request Dec 4, 2024
@canbaytok @waffle87
@dunk2k @drashna @pull
[Keyboard] Add cans12erv2 (qmk#24628)
a934600 
Co-authored-by: jack <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Can Baytok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@canbaytok @drashna @waffle87 @dunk2k