-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PySide6 Compatibility #1002
base: main
Are you sure you want to change the base?
PySide6 Compatibility #1002
Conversation
For ubuntu unit tests
Hoping this will resolve an issue with running tests and doc building
|
Thank you, @shanto268! The tests are running. This is a giant PR, so it would be good to have more eyes on it than just you and me. Has anyone else from your lab tried this? I think after merging this, we could bump the Qiskit Metal version from 0.1.5 to 0.2. I just want to make sure it runs. |
Thanks! All tests have passed now, thankfully. I totally agree—it indeed is a big PR, so having more eyes on it is a great idea. I’ll be using this version myself and asking my lab mates to do the same over the next couple of weeks. If everything runs smoothly, I’ll report back. I’d also like to invite the great people—@PP501 and @DavidSomm—of the SQDMetal team to see if they can help beta test this version as well. |
Awesome, that would be superb! Thank you everyone. Please don't be shy to post any comments here. |
Nice |
What are the issues this pull addresses (issue numbers / links)?
Porting Qiskit Metal from PySide2 to PySide6 so that it can work natively on M* Macs (Apple Silicon).
Issues addressed:
Did you add tests to cover your changes (yes/no)?
No. N/A
Did you update the documentation accordingly (yes/no)?
Yes
Did you read the CONTRIBUTING document (yes/no)?
Yes
Summary
Fixed changes from PR #908 to pass automated CI workflows and tests, ensuring compatibility with updated dependencies, environment configurations, and the latest (11/17/2024)
main
branch.Details and comments
Built on top of changes made by @obrienpja in PR #908.
Changes to
QWidget_PlaceholderText
andQTableView_AllComponents
:QWidget_PlaceholderText
class to ensure proper initialization and compatibility withPySide6
.PySide6
standards.QTableView_AllComponents
to correctly inherit and integrate withQWidget_PlaceholderText
, ensuring both functionality and visual styling work seamlessly.Requirements and environment updates:
environment.yml
file to use stable, OS-agnostic dependencies for Python 3.10.pyaedt
, to ensure a consistent build across different operating systems.Testing and validation:
main
branch workflows to confirm identical behavior.