Merged
Conversation
Contributor
Author
* Black lint.
* Docstring, black and lint. * Improved fit guessing.
yaelbh
reviewed
Jun 6, 2021
nkanazawa1989
suggested changes
Jun 7, 2021
Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
* Added some circuit tests.
nkanazawa1989
approved these changes
Jun 16, 2021
* Improved fit guesses. * Improved tests.
nkanazawa1989
approved these changes
Jun 16, 2021
wshanks
approved these changes
Jun 17, 2021
Collaborator
wshanks
left a comment
wshanks
left a comment
There was a problem hiding this comment.
I put a couple questions but it looks good to me.
I wonder about allowing a pulse as an experiment option, but the schedule is probably good enough.
paco-ri
pushed a commit
to paco-ri/qiskit-experiments
that referenced
this pull request
Jul 11, 2022
* * Skeleton of the Rabi experiment. * * Completed the fit function. * * Added test for the rabi * * Added test and fixed variance issue. * * Added draft of end to end test. * * Added TODO. * * data processing and options. * * Updated the options for the Rabi experiment. * * Added more resilience in sigmas processing and a test. * * Improved tests. * * Refactored tests to use mock IQ backends. * Black lint. * * Improved fitting. * * Gave fit function variables comprehensive names. * Docstring, black and lint. * Improved fit guessing. * * black. * * Refactored tests based on IQ data to lighten the code. * Update qiskit_experiments/calibration/experiments/rabi.py Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com> * * Aligned Rabi API to current varsion. * Added some circuit tests. * * Fixed docstring typo. * * Docstring fix. * * Fix error message. * * Refactored mock_backend. * * Added np.integer to Probability node. * * Improved test. * * Fixed docstring and label. * * Aligned Rabi with the curve fitting PR. * * Improved the mock IQ backend. * * Black and lint. * * Added amplitude rounding. * * Added plot labels in defaults. * * Docstrings. * * Changed the label of the report. * * Remove normalization option in Rabi. * * Added normalization option to the Rabi experiment. * * Updated phase initial guesses. * * Moved normalization option from run to experiment options. * * Aligned Rabi with master. * Improved fit guesses. * Improved tests. * * Changed a and b to amp and baseline. * Added an extra test. * * Black. Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PR implements a Rabi experiment.
Details and comments
The Rabi experiment is implemented by scanning the amplitude of a single-qubit pulse such as a Drag or Gaussian pulse. Since a discriminator is typically not available the data is analyzed using a SVD. The resulting signal is then fit to a cosine function.