Skip to content

Rabi #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Jun 17, 2021
Merged

Rabi #74

merged 50 commits into from
Jun 17, 2021

Conversation

eggerdj
Copy link
Contributor

@eggerdj eggerdj commented Jun 1, 2021

Summary

The PR implements a Rabi experiment.

Details and comments

The Rabi experiment is implemented by scanning the amplitude of a single-qubit pulse such as a Drag or Gaussian pulse. Since a discriminator is typically not available the data is analyzed using a SVD. The resulting signal is then fit to a cosine function.

@eggerdj
Copy link
Contributor Author

eggerdj commented Jun 1, 2021

This PR first requires #31 to merge as #31 has relevant testing and data processing functionality.

@eggerdj eggerdj changed the title [WIP] Rabi Rabi Jun 3, 2021
Copy link
Collaborator

@yaelbh yaelbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There see

@eggerdj eggerdj added this to the Release 1 milestone Jun 14, 2021
eggerdj and others added 2 commits June 16, 2021 10:16
* Improved fit guesses.
* Improved tests.
Copy link
Collaborator

@wshanks wshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put a couple questions but it looks good to me.

I wonder about allowing a pulse as an experiment option, but the schedule is probably good enough.

@eggerdj eggerdj merged commit 8693ba9 into qiskit-community:main Jun 17, 2021
@eggerdj eggerdj deleted the rabi branch June 17, 2021 19:21
paco-ri pushed a commit to paco-ri/qiskit-experiments that referenced this pull request Jul 11, 2022
* * Skeleton of the Rabi experiment.

* * Completed the fit function.

* * Added test for the rabi

* * Added test and fixed variance issue.

* * Added draft of end to end test.

* * Added TODO.

* * data processing and options.

* * Updated the options for the Rabi experiment.

* * Added more resilience in sigmas processing and a test.

* * Improved tests.

* * Refactored tests to use mock IQ backends.
* Black lint.

* * Improved fitting.

* * Gave fit function variables comprehensive names.
* Docstring, black and lint.
* Improved fit guessing.

* * black.

* * Refactored tests based on IQ data to lighten the code.

* Update qiskit_experiments/calibration/experiments/rabi.py

Co-authored-by: Naoki Kanazawa <[email protected]>

* * Aligned Rabi API to current varsion.
* Added some circuit tests.

* * Fixed docstring typo.

* * Docstring fix.

* * Fix error message.

* * Refactored mock_backend.

* * Added np.integer to Probability node.

* * Improved test.

* * Fixed docstring and label.

* * Aligned Rabi with the curve fitting PR.

* * Improved the mock IQ backend.

* * Black and lint.

* * Added amplitude rounding.

* * Added plot labels in defaults.

* * Docstrings.

* * Changed the label of the report.

* * Remove normalization option in Rabi.

* * Added normalization option to the Rabi experiment.

* * Updated phase initial guesses.

* * Moved normalization option from run to experiment options.

* * Aligned Rabi with master.
* Improved fit guesses.
* Improved tests.

* * Changed a and b to amp and baseline.
* Added an extra test.

* * Black.

Co-authored-by: Naoki Kanazawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants