minor fixes from latests ENA and SPP changes #3472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -75,3 +75,6 @@ notebooks/*/*.tsv.gz | |||
|
|
|||
| # jupyter notebooks input data | |||
| notebooks/resource-allocation/data | |||
|
|
|||
| # ignore plugin SQL injection file | |||
| qiita_db/support_files/patches/test_db_sql/91.sql | |||
There was a problem hiding this comment.
Why shouldn't the patch file go into git? Does it have sensitive info in it or something?
There was a problem hiding this comment.
Good question! Patch 91.sql doesn't actually exist, see https://github.com/qiita-spots/qiita/blob/master/CONTRIBUTING.md#patch-91sql. However, this can be used to "inject" SQL for extra plugin testing, like https://github.com/qiita-spots/qp-knight-lab-processing/blob/main/tests/qiita-sql/91.sql. Note that raw/non-testing deployment will never hit this as the patching starts in 92.
AmandaBirmingham
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.