Skip to content
This repository has been archived by the owner on Sep 23, 2023. It is now read-only.

add account details and fix login redirect on emp #659

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

teravest
Copy link
Contributor

fixes#655
fixes#623

This changes the emp login page to redirect to the system you are not production.
This also adds the 'create account', 'forgot password' and 'change password' links to the emp login page.

This also changes those 3 pages to be stylized based on emp or qiime.

It needs to be tested on webdev because of the email issues...

@adamrp
Copy link
Member

adamrp commented Mar 27, 2014

Cool! Is it deployed on webdev currently?

On Thu, Mar 27, 2014 at 2:39 PM, teravest [email protected] wrote:

fixes#655
fixes#623

This changes the emp login page to redirect to the system you are not
production.
This also adds the 'create account', 'forgot password' and 'change
password' links to the emp login page.

This also changes those 3 pages to be stylized based on emp or qiime.

It needs to be tested on webdev because of the email issues...

You can merge this Pull Request by running

git pull https://github.com/teravest/qiime_web_app issue655

Or view, comment on, or merge it at:

#659
Commit Summary

  • add account details and fix login redirect on emp

File Changes

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com//pull/659
.

@teravest
Copy link
Contributor Author

It is now! And it looks to me like its working :) But i didnt try to
reset my password...

On Thu, Mar 27, 2014 at 3:15 PM, adamrp [email protected] wrote:

Cool! Is it deployed on webdev currently?

On Thu, Mar 27, 2014 at 2:39 PM, teravest [email protected]
wrote:

fixes#655
fixes#623

This changes the emp login page to redirect to the system you are not
production.
This also adds the 'create account', 'forgot password' and 'change
password' links to the emp login page.

This also changes those 3 pages to be stylized based on emp or qiime.

It needs to be tested on webdev because of the email issues...

You can merge this Pull Request by running

git pull https://github.com/teravest/qiime_web_app issue655

Or view, comment on, or merge it at:

#659
Commit Summary

  • add account details and fix login redirect on emp

File Changes

Patch Links:

Reply to this email directly or view it on GitHub<
https://github.com/qiime/qiime_web_app/pull/659>
.

Reply to this email directly or view it on GitHubhttps://github.com//pull/659#issuecomment-38861624
.

<title>Qiime</title>
<%
if 'portal_type' in form:
req.write('<title>EMP</title>')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <title> on most other pages is "Earth Microbiome Project", can you change it to that please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I can do that.

On Fri, Mar 28, 2014 at 11:22 AM, adamrp [email protected] wrote:

In www/change_password.psp:

@@ -19,10 +19,22 @@ import gc

-<title>Qiime</title> +<% +if 'portal_type' in form: - req.write('<title>EMP</title>')

The <title> on most other pages is "Earth Microbiome Project", can you
change it to that please?

Reply to this email directly or view it on GitHubhttps://github.com//pull/659/files#r11075982
.

@adamrp
Copy link
Member

adamrp commented Mar 28, 2014

Changing my password on webdev (regardless of qiime or emp portal) does not work.

@teravest
Copy link
Contributor Author

I also noticed the password change didn't work on webdev... I don't think
that is related to my change though...

On Fri, Mar 28, 2014 at 11:35 AM, adamrp [email protected] wrote:

Changing my password on webdev (regardless of qiime or emp portal) does
not work.

Reply to this email directly or view it on GitHubhttps://github.com//pull/659#issuecomment-38946706
.

@teravest
Copy link
Contributor Author

teravest commented Apr 1, 2014

this is on webdev. It appears to be work the same as live, but that is not correct...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EMP login page doesnt have reset password option Emp login redirects to www
2 participants