Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve locator titles and groups visibility #60689

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

3nids
Copy link
Member

@3nids 3nids commented Feb 20, 2025

improve locator titles and groups visibility by using bold text

before:
image

now:
image

former version of this PR:
image

@github-actions github-actions bot added this to the 3.42.0 milestone Feb 20, 2025
@3nids
Copy link
Member Author

3nids commented Feb 20, 2025

I would be in favor of merging before tomorrow's release, but no strong opinion.

Copy link

github-actions bot commented Feb 20, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit bd6f2fa)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit bd6f2fa)

@nicogodet
Copy link
Member

Just exposing my thoughts, in your example, I feel that Cantons, District should not be in bold font but instead italic and underlined ?
But I'm in favor for this change, I also find hard to distinguish locator form another

@3nids
Copy link
Member Author

3nids commented Feb 21, 2025

that would be like this
image
the fact that the spacing before the group is also underline is something to consider

@3nids
Copy link
Member Author

3nids commented Feb 21, 2025

I've played a bit more using a background alternate color for titles and groups and use the main text color for any text:
image

dark mode:
image

I've updated the main description with this screenshot.

@3nids 3nids requested a review from nirvn February 21, 2025 08:38
@nicogodet
Copy link
Member

the fact that the spacing before the group is also underline is something to consider

Indeed, not very satisfying.

I like the second proposal 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants