Fix variable shadowing in new_path_with_id#3
Open
Aperence wants to merge 1 commit intoqdeconinck:multipath-ietf-122-fips-okfrom
Open
Fix variable shadowing in new_path_with_id#3Aperence wants to merge 1 commit intoqdeconinck:multipath-ietf-122-fips-okfrom
Aperence wants to merge 1 commit intoqdeconinck:multipath-ietf-122-fips-okfrom
Conversation
In the current version, whenever a scid is None when calling new_with_path_id, the reset token associated to a dcid is also set to None, even if it had a value before. This leads to errors in the verification of the CID if a NEW_PATH_CONNECTION_ID is retransmitted (e.g.: because it was lost), as reset tokens differs. This patch fixes this issue by deleting the variable shadowing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current version, whenever a scid is None when calling new_with_path_id, the reset token associated to a dcid is also set to None, even if it had a value before. This leads to errors in the verification of the CID if a NEW_PATH_CONNECTION_ID is retransmitted (e.g.: because it was lost), as reset tokens differs.
This patch fixes this issue by deleting the variable shadowing.