-
Notifications
You must be signed in to change notification settings - Fork 6
Feature: alternate subcat support #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
geoffrey-wu
merged 9 commits into
qbreader:main
from
sreyassabbani:feat/8-alt-subcat-support
Jan 17, 2025
Merged
Feature: alternate subcat support #14
geoffrey-wu
merged 9 commits into
qbreader:main
from
sreyassabbani:feat/8-alt-subcat-support
Jan 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modified `_api_utils.py` - breaking change to `normalize_subcats()` function
…ync` and `Async` clients.
This should be what I intended to PR.
Contributor
Author
|
I did see some oopsies after PR-ing. I believe we're going to have to squash those commits before merging. |
This was
linked to
issues
Jan 17, 2025
Member
|
I added some commits, the gist is that:
|
sreyassabbani
added a commit
to sreyassabbani/qbreader-python-module
that referenced
this pull request
Jan 17, 2025
sreyassabbani
added a commit
to sreyassabbani/qbreader-python-module
that referenced
this pull request
Jan 17, 2025
geoffrey-wu
added a commit
that referenced
this pull request
Mar 7, 2025
fix(lint): resolve errors from merged PR #14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8
This should work now, for both tossups & bonuses on both
SyncandAsyncclients.Example:
This will send a GET request to the QB Reader API endpoint, automatically adding
subcategories=Other%20Literatureon to the querystring.And for the async example: