Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: diverging colormaps for B0 chapter #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mathieuboudreau
Copy link
Member

Following up on #12, I'm suggesting to switch the B0 maps from grayscale to a diverging colormap (I have a preference of blue-white-red since it's intuitive), with white set to 0, blue negatives, red positives. I'm open to a discussion, how are they being displayed in Shimming-Toolbox?

Here's what they look like with my changes,

Figure 5.1

5-1-1

Figure 5.3

5-1-3-1

5-1-3-2

Figure 5.9

5-2-4

Copy link
Member

@agahkarakuzu agahkarakuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks great to me, thanks!

Before merging, wanted to give you heads up that the deploy workflow on main sets mb/dev as trigger ref

branches: mb/dev

@mathieuboudreau
Copy link
Member Author

It all looks great to me, thanks!

Before merging, wanted to give you heads up that the deploy workflow on main sets mb/dev as trigger ref

branches: mb/dev

Yep thanks! I was about to change it to main again last night but fell asleep haha - will do asap

Copy link

@po09i po09i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree! I think the colormaps are much better than greyscale!

@mathieuboudreau
Copy link
Member Author

Thanks all! I was about to merge when I noticed the colors are going the wrong way (blue should be negative and red positive) - I think plotly has two different definitions for this diverging colormap - I'll look up the other one and fix it prior to merge!

@po09i
Copy link

po09i commented Oct 14, 2024

the colors are going the wrong way

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants