Improve test coverage #176
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
- Coverage 95.27% 94.59% -0.68%
==========================================
Files 2 2
Lines 148 148
Branches 0 23 +23
==========================================
- Hits 141 140 -1
+ Misses 7 5 -2
- Partials 0 3 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Coverage is reporting misses... Will need to investigate |
This reverts commit cb41a33.
pytest_pyvista/pytest_pyvista.py
Outdated
| if self.failed_image_dir is not None and not Path(image_filename).is_file(): | ||
| # Image comparison will fail, so save image before error | ||
| self._save_failed_test_images("error", plotter, image_name) | ||
| remove_plotter_close_callback() |
There was a problem hiding this comment.
This branch was identified as possibly redundant and unnecessary in #171 (comment), and #175 fixed the earlier logic such that, with branch coverage enabled by this PR, this branch has been identified as missing coverage and hence is not executed and is therefore not needed.
|
Coverage report is working, and now only a single (partial) miss is reported. The missing branch is for the |
Use
--branchto report partial misses and add tests for branches without coverage.