-
Notifications
You must be signed in to change notification settings - Fork 566
Update PyTorch and XLA pin. #9668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,390
−82
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9c30add
Update pins.
ysiraichi 3042439
Add commit reference.
ysiraichi 8e91c05
Fix lint.
ysiraichi 8af438e
Add OpenXLA patch.
ysiraichi 6ea2902
Unpin flax, but check for conflicts.
ysiraichi 488d8c6
Remove TPU prefix.
ysiraichi 1b508b9
Remove pip check.
ysiraichi 11fa7be
Fix sharding test HLO.
ysiraichi 15d8817
Fix lint.
ysiraichi 66164c8
Fix test.
ysiraichi 8a5a0d5
fix xla sharding tests
bhavya01 2f1e61c
Update opt-barrier test
bhavya01 bf1e0e7
Remove flax install from CI
bhavya01 63a4600
Remove shard_as test
bhavya01 e7f0765
Add back flax
bhavya01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
# 2025-09-17 | ||
928ac57c2ab03f9f79376f9995553eea2e6f4ca8 | ||
# 2025-09-29 | ||
21fec65781bebe867faf209f89bb687ffd236ca4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
diff --git a/xla/python/ifrt/attribute_map.h b/xla/python/ifrt/attribute_map.h | ||
index a8c9f11c8d..e5bb70bcf8 100644 | ||
--- a/xla/python/ifrt/attribute_map.h | ||
+++ b/xla/python/ifrt/attribute_map.h | ||
@@ -106,7 +106,9 @@ class AttributeMap { | ||
} else if constexpr (std::is_same_v<T, float>) { | ||
return Get<T, FloatValue>(key); | ||
} else { | ||
- static_assert(false, "Unsupported type for AttributeMap::Get"); | ||
+ // Same as: static_assert(false). | ||
+ // Make it compileable by GCC version < 13. | ||
+ static_assert(!sizeof(T), "Unsupported type for AttributeMap::Get"); | ||
} | ||
} | ||
|
||
diff --git a/xla/stream_executor/plugin_registry.cc b/xla/stream_executor/plugin_registry.cc | ||
index f16a4f6707..8bfd51b238 100644 | ||
--- a/xla/stream_executor/plugin_registry.cc | ||
+++ b/xla/stream_executor/plugin_registry.cc | ||
@@ -41,7 +41,9 @@ PluginKind GetPluginKind() { | ||
} else if constexpr (std::is_same_v<FactoryT, PluginRegistry::FftFactory>) { | ||
return PluginKind::kFft; | ||
} else { | ||
- static_assert(false, "Unsupported factory type"); | ||
+ // Same as: static_assert(false). | ||
+ // Make it compileable by GCC version < 13. | ||
+ static_assert(!sizeof(FactoryT), "Unsupported factory type"); | ||
} | ||
} | ||
template <typename FactoryT> | ||
@@ -53,7 +55,9 @@ absl::string_view GetPluginName() { | ||
} else if constexpr (std::is_same_v<FactoryT, PluginRegistry::FftFactory>) { | ||
return "FFT"; | ||
} else { | ||
- static_assert(false, "Unsupported factory type"); | ||
+ // Same as: static_assert(false). | ||
+ // Make it compileable by GCC version < 13. | ||
+ static_assert(!sizeof(FactoryT), "Unsupported factory type"); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.