Dynamic expand with SymInt implementation
#3702
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miladm
commented
Jul 14, 2022
| return at::native::call_fallback_fn<&xla_cpu_fallback, | ||
| ATEN_OP(nonzero)>::call(self); | ||
| } | ||
| /* |
There was a problem hiding this comment.
To avoid breaking pt/xla for users without dynamic shape needs, I plan to uncomment this block after getting LGTM from reviewers. We continue to rely on the experimental flags for a little longer.
We should discuss the process to remove this code soon.
There was a problem hiding this comment.
Will looking adopting a temp approach like LTC_ENABLE_DYNAMIC_SHAPES.
miladm
added
DO_NOT_MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of issue #3558.
Blockers
test_torch.test_logcumsumexp_xlafails inexpand.SymInttests #3707