Skip to content

sava image_path in target of coco annotation data #8958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

developer0hye
Copy link
Contributor

The current version only saves the image_id into the target, making it difficult to identify the image intuitively. To address this, I've added image_path to the target, which provides intuitive information and makes debugging easier for users during development.

Copy link

pytorch-bot bot commented Mar 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8958

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@developer0hye developer0hye changed the title sava image_path in target sava image_path in target of coco annotation format data Mar 8, 2025
@developer0hye developer0hye changed the title sava image_path in target of coco annotation format data sava image_path in target of coco annotation data Mar 8, 2025
@AntoineSimoulin
Copy link
Member

Hey @developer0hye, thank you for submitting this PR! Your proposal looks great, but I suspect that most users may not require this information frequently. I would prefer to let users to reconstruct this information on a per-needed basis using the root dataset attribute and path = self.coco.loadImgs(id)[0]["file_name"] as you proposed. If you have a local version of the codebase that works well for you, I am inclined not to merge this PR at the moment.
Please feel free to share any additional thoughts or insights you might have.
Best,
Antoine

@developer0hye
Copy link
Contributor Author

@AntoineSimoulin Thank you for your review! I agree with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants