Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DistributedModelParallel links in torchrec_intro_tutorial #3235

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

guspan-tanadi
Copy link
Contributor

@guspan-tanadi guspan-tanadi commented Jan 19, 2025

Fixes #

Description

Checklist

  • The issue that is being fixed is referred in the description
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @svekars @sekyondaMeta @AlannaBurke

Copy link

pytorch-bot bot commented Jan 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3235

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 65253e8 with merge base 63295e8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars
Copy link
Contributor

svekars commented Jan 21, 2025

@guspan-tanadi thank you for the PR - I was wondering if you can fix other links too? See: https://github.com/pytorch/tutorials/actions/runs/12855061734/job/35937409459?pr=3235

@svekars svekars added the skip-link-check Will allow you to skip linkcheck on a PR. Should only should be used when a link can't be fixed. label Jan 28, 2025
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as stale.
Feel free to remove the stale label if you feel this was a mistake.
If you are unable to remove the stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale Stale PRs label Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed incorrect link skip-link-check Will allow you to skip linkcheck on a PR. Should only should be used when a link can't be fixed. stale Stale PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants