Do full GC for checkpointing related GC calls #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`gc.collect(1)` is not enough for checkpoint related actions. For example, DCP.async_save() may cause memory leakage and doing `gc.collect(1)` won't fix it. This may slow down `async_save` and zero-overhead checkpointing.
facebook-github-bot
added
the
CLA Signed
|
This may be false positive, we may not need this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gc.collect(1)is not enough for checkpoint related actions. For example, DCP.async_save() may cause memory leakage and doinggc.collect(1)won't fix it. This may slow downasync_saveand zero-overhead checkpointing.