JSON config support for cmd_conf utility #3227
Open
+36
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78833153 |
SSYernar
force-pushed
the
export-D78833153
branch
from
755187b to
d7bca53
Compare
SSYernar
added a commit
to SSYernar/torchrec
that referenced
this pull request
Jul 30, 2025
Summary:
Added a support for JSON file configuration of cmd_conf decorator for benchmark parameters parsing. This feature makes easier to reproduce complex configurations without the need to pass CLI arguments.
Example .json file should look like:
```
{
"RunOptions": {
"world_size": 1,
"num_batches": 3
},
"PipelineConfig": {
"pipeline": "sparse"
}
}
```
Also, configs can be listed in a 'flat' way as well:
```
{
"world_size": 2,
"num_batches": 3,
"pipeline": "base"
}
```
To run, add `--json_config` flag with the .json file path. JSON configs will override YAML configs if both are given.
Reviewed By: aliafzal
Differential Revision: D78833153
|
This pull request was exported from Phabricator. Differential Revision: D78833153 |
SSYernar
added a commit
to SSYernar/torchrec
that referenced
this pull request
Jul 30, 2025
Summary: Pull Request resolved: pytorch#3227 Added a support for JSON file configuration of cmd_conf decorator for benchmark parameters parsing. This feature makes easier to reproduce complex configurations without the need to pass CLI arguments. Example .json file should look like: ``` { "RunOptions": { "world_size": 1, "num_batches": 3 }, "PipelineConfig": { "pipeline": "sparse" } } ``` Also, configs can be listed in a 'flat' way as well: ``` { "world_size": 2, "num_batches": 3, "pipeline": "base" } ``` To run, add `--json_config` flag with the .json file path. JSON configs will override YAML configs if both are given. Reviewed By: aliafzal Differential Revision: D78833153
SSYernar
force-pushed
the
export-D78833153
branch
from
d7bca53 to
61fe65f
Compare
SSYernar
added a commit
to SSYernar/torchrec
that referenced
this pull request
Jul 31, 2025
Summary:
Added a support for JSON file configuration of cmd_conf decorator for benchmark parameters parsing. This feature makes easier to reproduce complex configurations without the need to pass CLI arguments.
Example .json file should look like:
```
{
"RunOptions": {
"world_size": 1,
"num_batches": 3
},
"PipelineConfig": {
"pipeline": "sparse"
}
}
```
Also, configs can be listed in a 'flat' way as well:
```
{
"world_size": 2,
"num_batches": 3,
"pipeline": "base"
}
```
To run, add `--json_config` flag with the .json file path. JSON configs will override YAML configs if both are given.
Reviewed By: aliafzal
Differential Revision: D78833153
SSYernar
force-pushed
the
export-D78833153
branch
from
61fe65f to
59365ef
Compare
Summary: Pull Request resolved: pytorch#3227 Added a support for JSON file configuration of cmd_conf decorator for benchmark parameters parsing. This feature makes easier to reproduce complex configurations without the need to pass CLI arguments. Example .json file should look like: ``` { "RunOptions": { "world_size": 1, "num_batches": 3 }, "PipelineConfig": { "pipeline": "sparse" } } ``` Also, configs can be listed in a 'flat' way as well: ``` { "world_size": 2, "num_batches": 3, "pipeline": "base" } ``` To run, add `--json_config` flag with the .json file path. JSON configs will override YAML configs if both are given. Reviewed By: aliafzal Differential Revision: D78833153
|
This pull request was exported from Phabricator. Differential Revision: D78833153 |
SSYernar
force-pushed
the
export-D78833153
branch
from
59365ef to
ddf4dc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added a support for JSON file configuration of cmd_conf decorator for benchmark parameters parsing. This feature makes easier to reproduce complex configurations without the need to pass CLI arguments.
Example .json file should look like:
Also, configs can be listed in a 'flat' way as well:
To run, add
--json_configflag with the .json file path. JSON configs will override YAML configs if both are given.Differential Revision: D78833153