Refactor _batch_cal_norm and remove #pyre-ignore
#3200
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78398248 |
… L2 norm (pytorch#3220) Summary: Pull Request resolved: pytorch#3220 Differential Revision: D78706038
Summary: As title. 1. Parse `norm_type` by `self._norm_type = float(norm_type)` at GradientClippingOptimizer `__init__()` immediately and only use `self._norm_type` later on so it's not susceptible to the error in D78326114. 2. Remove repeated `total_grad_norm` calculation 3. Fix #pyre errors. Reviewed By: aliafzal Differential Revision: D78398248
|
This pull request was exported from Phabricator. Differential Revision: D78398248 |
|
This pull request has been reverted by a32caed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As title. Remove repeated
total_grad_normcalculation and fix #pyre errors.Differential Revision: D78398248