Support ssd device propagation in Torch Rec for RecSys Inference #2961
+84
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74378974 |
jingsh
approved these changes
May 8, 2025
|
This pull request was exported from Phabricator. Differential Revision: D74378974 |
faran928
added a commit
to faran928/torchrec
that referenced
this pull request
May 12, 2025
…orch#2961) Summary: For RecSys Inference when tables are offloaded onto SSD: 1. Specify and propagate the tables to be offloaded to SSD in TorchRec via FUSED_PARAMS as discussed with TroyGarden 2. Continue using torch.device("cpu") as compute device while using separate input / output dist for SSD (as in house SSD TBE kernel based on EmbeddingDB is different than CPU TBE kernel) by creating a new device group for SSD. Would be renaming device_type_from_sharding_info to storage_device_type_from_sharding_info to clarify it better. Differential Revision: D74378974
faran928
force-pushed
the
export-D74378974
branch
from
0559aff to
0274c28
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74378974 |
faran928
added a commit
to faran928/torchrec
that referenced
this pull request
May 12, 2025
…orch#2961) Summary: Pull Request resolved: pytorch#2961 For RecSys Inference when tables are offloaded onto SSD: 1. Specify and propagate the tables to be offloaded to SSD in TorchRec via FUSED_PARAMS as discussed with TroyGarden 2. Continue using torch.device("cpu") as compute device while using separate input / output dist for SSD (as in house SSD TBE kernel based on EmbeddingDB is different than CPU TBE kernel) by creating a new device group for SSD. Would be renaming device_type_from_sharding_info to storage_device_type_from_sharding_info to clarify it better. Differential Revision: D74378974
faran928
force-pushed
the
export-D74378974
branch
from
0274c28 to
41cbba8
Compare
…orch#2961) Summary: For RecSys Inference when tables are offloaded onto SSD: 1. Specify and propagate the tables to be offloaded to SSD in TorchRec via FUSED_PARAMS as discussed with TroyGarden 2. Continue using torch.device("cpu") as compute device while using separate input / output dist for SSD (as in house SSD TBE kernel based on EmbeddingDB is different than CPU TBE kernel) by creating a new device group for SSD. Would be renaming device_type_from_sharding_info to storage_device_type_from_sharding_info to clarify it better. Reviewed By: jiayisuse Differential Revision: D74378974
faran928
force-pushed
the
export-D74378974
branch
from
41cbba8 to
94c4638
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74378974 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For RecSys Inference when tables are offloaded onto SSD:
Would be renaming device_type_from_sharding_info to storage_device_type_from_sharding_info to clarify it better.
Differential Revision: D74378974