Fix RW Support and checkpointing #2890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73144116 |
doIIarplus
pushed a commit
to doIIarplus/torchrec
that referenced
this pull request
Apr 17, 2025
Summary: Fixes a bug in RW / TWRW checkpointing where the buffers being saved wouldn't represent all of the shards that existed during training. Reviewed By: Nayef211 Differential Revision: D73144116
doIIarplus
force-pushed
the
export-D73144116
branch
from
e4397a7 to
0d947ab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73144116 |
doIIarplus
pushed a commit
to doIIarplus/torchrec
that referenced
this pull request
Apr 17, 2025
Summary: Pull Request resolved: pytorch#2890 Fixes a bug in RW / TWRW checkpointing where the buffers being saved wouldn't represent all of the shards that existed during training. Reviewed By: Nayef211 Differential Revision: D73144116
doIIarplus
force-pushed
the
export-D73144116
branch
from
0d947ab to
22b94fa
Compare
doIIarplus
pushed a commit
to doIIarplus/torchrec
that referenced
this pull request
Apr 17, 2025
Summary: Fixes a bug in RW / TWRW checkpointing where the buffers being saved wouldn't represent all of the shards that existed during training. Reviewed By: Nayef211 Differential Revision: D73144116
doIIarplus
force-pushed
the
export-D73144116
branch
from
22b94fa to
a21c15d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73144116 |
doIIarplus
pushed a commit
to doIIarplus/torchrec
that referenced
this pull request
Apr 17, 2025
Summary: Pull Request resolved: pytorch#2890 Fixes a bug in RW / TWRW checkpointing where the buffers being saved wouldn't represent all of the shards that existed during training. Reviewed By: Nayef211 Differential Revision: D73144116
doIIarplus
force-pushed
the
export-D73144116
branch
2 times, most recently
from
28c82cd to
bb3b462
Compare
doIIarplus
pushed a commit
to doIIarplus/torchrec
that referenced
this pull request
Apr 18, 2025
Summary: Fixes a bug in RW / TWRW checkpointing where the buffers being saved wouldn't represent all of the shards that existed during training. Reviewed By: Nayef211 Differential Revision: D73144116
Summary: Pull Request resolved: pytorch#2890 Fixes a bug in RW / TWRW checkpointing where the buffers being saved wouldn't represent all of the shards that existed during training. Reviewed By: Nayef211 Differential Revision: D73144116
|
This pull request was exported from Phabricator. Differential Revision: D73144116 |
doIIarplus
force-pushed
the
export-D73144116
branch
from
bb3b462 to
1e8c95a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fixes a bug in RW / TWRW checkpointing where the buffers being saved wouldn't represent all of the shards that existed during training.
Reviewed By: Nayef211
Differential Revision: D73144116