support multiple outer optims for diloco #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
tushar00jain
requested review from
Copilot,
d4l3k,
H-Huang and
dzmitry-huba
and removed request for
d4l3k
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying a different outer optimizer per fragment and introduces a fragment_update_alpha parameter to blend local and global updates. It also updates tests to cover the new alpha values and maintains backward compatibility with a single optimizer.
- Allow
outer_optimizerto be a list, enforcing one optimizer per fragment. - Save, clear, and merge local parameters using
fragment_update_alpha. - Update integration tests to include
alphain parameterized configurations.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| torchft/local_sgd.py | Added dictionaries and methods to save, merge, and clear local parameters; support list of optimizers; removed old alpha guard |
| torchft/local_sgd_integ_test.py | Updated test configs and signatures to include alpha parameter |
| @@ -557,12 +598,6 @@ def __init__( | |||
| if fragment_update_alpha < 0 or fragment_update_alpha > 1: | |||
| raise ValueError("fragment_update_alpha must be between 0 and 1") | |||
|
|
|||
There was a problem hiding this comment.
The fragment_update_alpha value is validated but never stored on the instance. Add self._fragment_update_alpha = fragment_update_alpha after the validation so _merge_parameters can access it.
Suggested change
| self._fragment_update_alpha = fragment_update_alpha |
Copilot uses AI. Check for mistakes.
Summary: - merge local and global parameters of the model after synchronization - add the "alpha" parameter to integration tests Test Plan: ``` pytest -vs ./torchft/local_sgd_integ_test.py ```
Summary: - support passing in a different outer optimizer for each fragment - currently accept both list of optimizers and a single optimizer for backward compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Stack created with Sapling. Best reviewed with ReviewStack.