Skip to content

Revert D72722867: Multisect successfully blamed "D72475332: [torchcodec][diff_train] Make device interface generic (#606)" for one test failure #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

scotts
Copy link
Contributor

@scotts scotts commented Apr 10, 2025

Summary:
This diff reverts D72722867
D72475332: [torchcodec][diff_train] Make device interface generic (#606) by generatedunixname499836121 causes the following test failure:

Tests affected:

Here's the Multisect link:
https://www.internalfb.com/multisect/25810176
Here are the tasks that are relevant to this breakage:
T191383700: 100+ tests, 10+ build rules, some CI signals unhealthy for offline_inference

The backout may land if someone accepts it.

If this diff has been generated in error, you can Commandeer and Abandon it.

Reviewed By: scotts

Differential Revision: D72775487

…ec][diff_train] Make device interface generic (pytorch#606)" for one test failure

Summary:
This diff reverts D72722867
D72475332: [torchcodec][diff_train] Make device interface generic (pytorch#606) by generatedunixname499836121 causes the following test failure:

Tests affected:
- [cogwheel:cogwheel_fblearner_inferno_hello_world#main](https://www.internalfb.com/intern/test/844425115815788/)

Here's the Multisect link:
https://www.internalfb.com/multisect/25810176
Here are the tasks that are relevant to this breakage:
T191383700: 100+ tests, 10+ build rules, some CI signals unhealthy for offline_inference

The backout may land if someone accepts it.

If this diff has been generated in error, you can Commandeer and Abandon it.

Reviewed By: scotts

Differential Revision: D72775487
@pytorch-bot pytorch-bot bot added the ci-no-td label Apr 10, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 10, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72775487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-td CLA Signed This label is managed by the Meta Open Source bot. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants