Move torchcodec/decoders/_core into torchcodec/_core
#609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_metadata.py" This reverts commit 31e806e.
facebook-github-bot
added
the
CLA Signed
scotts
approved these changes
Apr 1, 2025
dvrogozh
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
Thank you for heads up, @NicolasHug. Rebase of #606 should not be a problem.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_corefolder currently contains all the C++ code, the metadata and the custom ops. Part of it will also be relevant for encoding (typically FFmpeg utils, and potentially sample format conversion). As a result, this PR moves the_corefolder away fromdecoders/.Public APIs and import remain unchanged
There will be 2 follow-ups:
test/structure should be updatedHeads up @dvrogozh that this PR will likely create merge conflicts with #606, but they should be straightforward to resolve.